Repository navigation
Migrate coverage pipeline to score_coverage 0.3.1 - #235
Merged
Merged
Conversation
The LLVM coverage pipeline under @score_tooling//coverage moved to its
own qualified module, score_coverage (eclipse-score/coverage_tool,
TCL LOW). Switch the labels one-to-one, add the module as a dev
dependency and set --instrumentation_filter=^//score[/:] as the 0.3.1
manual requires (Bazel's guessed filter covers only the packages of the
test targets). Scope, config, justification file, workflow and the gate
at 85 are otherwise unchanged. The scope comment no longer calls the
cc_binary entry-point sources a gap: the module collects them and lists
them as no-data in unmapped_files.txt.
Local comparison, //score/... (51 tests), old pipeline vs this commit,
LCOV compared record by record:
files in report 86 -> 86
identical status 84 of 86
raw line coverage 87.25 % -> 87.18 %
effective line cov. 89.34 % -> 89.26 % (58 justified lines, same
justifications applied, same stale entry)
raw branch coverage 81.43 % -> 81.43 %
The two status differences are environment effects, not the pipeline:
pdelay_measurer.cpp flips between two runs of the new module as well
(timestamp-dependent checks), and shared_memory_handler.h lines
110-111 are the construct callback that runs only when the shared
memory segment is created rather than reopened.
Tracking: eclipse-score/score#3258
Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
This was referenced Sep 30, 2026
lavrovvalera
approved these changes
Oct 1, 2026
Contributor
Author
|
@NEOatNHNG could you review this one, please? It moves the coverage pipeline to the qualified |
Contributor
|
Quality pack traceability report for this pull request: Status: PASS (workflow run) |
NEOatNHNG
approved these changes
Oct 9, 2026
Contributor
|
Documentation preview for this pull request is available at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollout of the qualified S-CORE coverage tool,
score_coverage0.3.1 (release notes), tracked in eclipse-score/score#3258. Linux LLVM coverage only.What
The coverage pipeline this repository used from
@score_tooling//coveragemoved to its own module. This PR switches the labels one-to-one (defs.bzl,merger,generate_coverage_html, the death-test feature), addsscore_coverage0.3.1 as a dev dependency and sets--instrumentation_filter=^//score[/:]in thellvm_covconfig, as the 0.3.1 manual requires: Bazel's guessed filter covers only the packages of the test targets, and a library tested from atestsubpackage without an instrumented dependency would otherwise be compiled without counters. Scope, justification file, workflow and the gate at 85 are otherwise unchanged. The scope comment no longer calls thecc_binaryentry-point sources a gap: the module collects them and lists them asno-data.Verification
Local,
bazel coverage --config=llvm_cov //score/... --build_tests_only(51 tests), old pipeline vs this branch, LCOV compared record by record:verification_machine.h:173) reported in bothbazel build --nobuild --lockfile_mode=error //...,bazel mod tidyThe two differing files are environment effects, not the pipeline.
gptp/details/pdelay_measurer.cppflips between two consecutive runs of the new module as well (checks on timestamp values).ipc/core/shared_memory_handler.hlines 110–111 are the construct callback ofCreateOrOpen, which runs only when the shared-memory segment is created rather than reopened; the baseline run created it, later runs on the same machine reopened it.New in the archive.
unmapped_files.txtlists in-scope files without any coverage data: 19declaration-onlyheaders and 29no-datafiles. Among the latter are the entry points (main.cpp,time_daemon.cpp,time_slave.cpp), thets_clientIPC headers and several hook/traits headers. None of these had data before either; they were simply not listed. Worth a look by the module owners.